Commit Graph

51 Commits

Author SHA1 Message Date
Dmitry Smirnov e74f095fe1 fix handling of cuesheets with 99 tracks (Debian #658818)
There's an off-by-one error in cd.c which causes cueprint to wrongly reject
 cuesheets with 99 tracks.  Its actual limit is 98 tracks, and yet as the
 source code notes, the Red Book audio standard permits 99 tracks per disc
 (and 99 indices per track).
 .
 When I looked into this, I saw that:
 .
 1) not only will the same error occur with index numbers, but
 2) the wrong preprocessor symbol is being expanded when checking the index number

Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658818
From: Branden Robinson <branden@debian.org>
Author: Dmitry Smirnov <onlyjob@member.fsf.org>
2013-07-05 17:50:02 +10:00
Dmitry Smirnov 6ef317d871 ability to specify field list (for Ogg/Flac), as well as specify field contents (Debian: #655078)
It allows to call `cuetag` like so:

    cuetag Björk-Volta.cue *.ogg ARTIST ALBUM TITLE YEAR=2007 GENRE=electronic TRACKNUMBER

 which accomplishes two things:

  1. it pre-selects the fields and specifies their order;

  2. it hardcodes two fields to specific values for all tracks.

 Since the field list is hardcoded for MP3, any fields specified on
 the command line are effectively ignored. This could probably be
 implemented better, but I do not care about MP3 at all.

Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655078
From: martin f krafft <madduck@debian.org>
Author: Dmitry Smirnov <onlyjob@member.fsf.org>
2013-07-05 17:10:24 +10:00
Dmitry Smirnov 0c7f15be0b pad tracknumbers with leading zeroes (Debian #655079)
Ensures that tracknumbers are zero-padded to two digits.
That seems to be common usage.

Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655079
From: martin f krafft <madduck@debian.org>
2013-07-05 16:41:19 +10:00
Dmitry Smirnov eb9bd4ff6c Use python-mutagen (mid3v2) or id3v2 instead of mp3info to tag (Debian: #676478)
This avoids truncating long titles/albums/etc.

Author: Felipe Sateler <fsateler@debian.org>
Reviewed-By: Dmitry Smirnov <onlyjob@member.fsf.org>
Thanks-To: Rogério Brito.
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=676478

 * Look for `mid3v2` first and fallback to `id3v2` according to their availability.
 * Added error message if neither of them found.
2013-07-05 15:40:44 +10:00
Dmitry Smirnov 521b7552de cueprint: use the correct type format string 2013-07-05 15:40:44 +10:00
Dmitry Smirnov efd39b282e X<Y<Z doesn't has the mathematical meaning in C. Replace with X<Y && Y<Z.
Thanks, Felipe Sateler <fsateler@debian.org>
2013-07-05 15:40:40 +10:00
Dmitry Smirnov 92980fd399 fix "Buffer overflow detected" in cueconvert (Debian #576367) 2013-07-05 15:40:39 +10:00
Dmitry Smirnov 26b7d5295f replaces confusing error message at comparing the file suffix (Debian #499445) 2013-07-05 15:40:39 +10:00
Dmitry Smirnov 3949cccc45 fix cli parameters for metaflac 2013-07-05 15:40:31 +10:00
Dmitry Smirnov 0b6ea663eb fix processing of filenames containing spaces 2013-07-05 15:40:21 +10:00
Svend Sorensen da68f9bb9b Update copyright date. 2007-12-12 19:43:36 +00:00
Svend Sorensen 00764bc468 Removed space between functions and opening (. 2006-06-01 00:07:44 +00:00
Svend Sorensen 01eb4f7a16 Added short comments. 2006-05-15 19:29:25 +00:00
Svend Sorensen 25b65cadfb Idomatic change to main's argv. 2006-05-15 19:24:05 +00:00
Svend Sorensen 0187210b4d Added space after =. 2006-05-15 17:28:17 +00:00
Svend Sorensen 3371db447b More comment cleanups. 2006-03-01 20:10:26 +00:00
Svend Sorensen 75d0e4cc11 Add comments to preprocessor directives per GNU coding standards. 2006-03-01 20:04:43 +00:00
Svend Sorensen 4cd9c91d9c Shortened long lines.
Added error: tag to error message.
Corrected output file format error message.
2006-03-01 19:55:51 +00:00
Svend Sorensen 61e4f0c66e Default PACAKGE_STRING was incorrect for cueconvert and cueprint. 2006-03-01 19:42:38 +00:00
Svend Sorensen a3149234c1 Modified the usage output to mimic GNU applications output. 2006-03-01 19:39:02 +00:00
Svend Sorensen 06448a1021 Imported cueprint fixes and improvements from Branden Robinson's Debian patch. 2006-03-01 01:18:24 +00:00
Svend Sorensen 68f2e31068 Reworded comment. 2006-03-01 01:03:25 +00:00
Svend Sorensen 88949994ea Imported cueconvert fixes and improvements from Debian's patch. 2006-03-01 00:43:44 +00:00
Svend Sorensen 65c192e582 Imported cuebreakpoints fixes and improvements from Debian's patch. 2006-03-01 00:33:38 +00:00
Svend Sorensen e2326e5db6 Standardize multiline comment blocks. 2006-02-23 22:45:55 +00:00
Svend Sorensen 156b19d0a9 Fixed type for getopt_long return value. 2006-02-23 22:27:47 +00:00
Svend Sorensen 43f3a89dec Removed test for zero pregap breakpoint from append mode. 2006-02-14 22:23:54 +00:00
Svend Sorensen 4897183eaa Updated copyright date for new year. 2006-02-14 21:43:17 +00:00
Svend Sorensen a894befb57 Do not print duplicate breakpoints (bug #5965). 2006-02-14 19:47:40 +00:00
Svend Sorensen c9775d368c Print all pregaps for track 1 in --split-gaps mode (bug #5965, part 1 of 2). 2006-02-14 01:04:44 +00:00
Svend Sorensen a724473fc3 Fixed swapped flags (bug #4831). 2006-02-14 00:31:59 +00:00
Svend Sorensen dab8521762 Added missing $. 2005-04-06 19:44:30 +00:00
Svend Sorensen 18295a66f2 Added VC text file support. 2005-04-06 19:21:55 +00:00
Svend Sorensen b485903e72 Backticks required an extra escape. 2005-04-06 18:38:01 +00:00
Svend Sorensen 131166c025 Fixed mistyped sh variable. 2005-04-06 18:28:56 +00:00
Svend Sorensen d6d9aca893 Removed single quoted string support. 2005-03-29 02:20:00 +00:00
Svend Sorensen 7530a4f581 Added braces around single statement blocks. 2005-03-26 21:15:13 +00:00
Svend Sorensen f9194714bf Corrected typo. 2005-03-24 19:57:41 +00:00
Svend Sorensen 4434c9ee50 Use parenthesis instead of backticks for command substitution. 2005-03-24 19:46:44 +00:00
Svend Sorensen 0e53f7ef35 Added version command line option. 2005-03-24 18:39:26 +00:00
Svend Sorensen 69a34cb4fc Moved cuetag.sh to src/tools/. 2005-03-24 12:57:13 +00:00
Svend Sorensen 24068b5a61 Added braces around single statement blocks. 2005-03-24 12:32:39 +00:00
Svend Sorensen 76988c8ef0 Added tag to file format enum. 2005-03-24 12:19:39 +00:00
Svend Sorensen 20a67b2fca Standardize code header comment block. 2005-03-24 12:07:26 +00:00
Svend Sorensen 9d61b497c2 Added descriptions to {cue,toc}_parse_prefix.h files. 2005-03-24 12:02:29 +00:00
Svend Sorensen 6745e99c6f Wrapped long lines.
Moved headers from HEADERS to SOURCES.
2005-03-24 11:53:23 +00:00
Svend Sorensen 03723a13ae Updated Copyright dates to 2005. 2005-03-24 11:26:59 +00:00
Svend Sorensen d3bc1848a2 Added standard comment block to {cue,toc}_parse_prefix.h files. 2005-03-24 11:23:24 +00:00
Svend Sorensen a80b0625d7 Added basic comments to all Makfile.am files. 2005-03-24 10:50:10 +00:00
Svend Sorensen 8af64b6f3e Removed old Makefile. 2005-03-22 08:05:52 +00:00